Members controller refactoring

[eurich]

No description provided.

[norv]

I tried to find in js as well, but at no avail I'm afraid. It does seem as a leftover, whose use has been replaced at some point in time with action_findmembers (formerly JSMembers())... This action_requestmembers() method comes from a SMF 2.0/2.1 Subs- function, which also doesn't seem actually called.

Unless we do things like $scripturl + '?action=re' + 'questm' + 'embers' (lol), I'd be tempted to say it isn't used... and test that! ;)

[emanuele45]

Searching around it was used in 1.1 (and maybe 1.0) to fill the PM names.

        <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
            function autocompleter(element)
[...]
                var toComplete = new autocompleter("to"), bccComplete = new autocompleter("bcc");
                toComplete.source = "', $scripturl, '?action=requestmembers;sesc=', $context['session_id'], ';search=";
                bccComplete.source = "', $scripturl, '?action=requestmembers;sesc=', $context['session_id'], ';search=";

But then in 2.0 SMF started to use the autosuggest and probably this has been kept for some kind of backward compatibility.

👍 for dropping it! :D

[norv]

and probably this has been kept for some kind of backward compatibility.

Or simply forgotten.

[emanuele45]

Of course that's another possibility. 👼

[norv]

Looking good to me, dropping some more code ftw :)