reworking updateStats() #984
Conversation
Signed-off-by: Spuds <spuds@spudsdesign.com>
…tion to use it Signed-off-by: Spuds <spuds@spudsdesign.com>
…o it as well Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
… it as well Signed-off-by: Spuds <spuds@spudsdesign.com>
|
oh that's interesting, travis build failed.. dunno if it's related to the former PR ( #982) and the db layer changes or just a broken test case?... @emanuele45 any ideas? |
|
Suggestion to read travis builds: when you click on Details, you have the list of builds that failed (at the moment the most important to use are the two at the top), you can click on the job id (17.1, 17.2, etc.), there you will see the output of the command line with all the errors. In this case, the most important is: That is a valid error: |
|
Say, this travis thing is cool ! |
… we can use it Signed-off-by: Spuds <spuds@spudsdesign.com>
|
oh, wow. that's really cool 👍 Thanks for the details, eman.. |
This is the rework of the rework of updateStats #402 and #397
Nutshell ... it breaks down update stats function in Subs and moves the specific updating functions to messages/topics/members/group subs as appropriate.
It leaves the handler in Subs so the updateStats('') calls do not change.
It does change the calls inside the subs themselves to use the code moved to those subs, so inside of for example messages.subs it would call updateMessageStats(); since its internal (although updateStats('message') would still work, just not as clean).