Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin js files - for discussion #995

Merged
merged 6 commits into from Nov 12, 2013
Merged

Conversation

emanuele45
Copy link
Contributor

I'm not sure how you feel about them, I always found these things almost useless (I seem to remember Ant felt the same).
Okay, the version check may have some point, though all the others are just an annoyance in most of the cases and an additional hurdle on "us" to maintain and serve, etc.

I removed those that I feel are plain useless, though, going through them I started thinking it is worth keep the table at that point.
The three left are:

  • current-version.js (a one liner or so)
  • detailed-version.js (another one that I feel may be removed, it's just causing confusion more than solve anything)
  • latest-news.js (a big bunch of text useless for 99% of the time).

My proposal:

  • drop detailed-version.js and latest-news.js,
  • drop the table,
  • move current-version.js to {db_prefix}settings and use a single line thing with the most recent version (I start thinking support support multiple versions is not a very cleaver idea, so the most recent should be enough),
  • add another check to the admin warnings if the current version is lower than the most recent.

That way we will fetch just one tiny file (ideally just the version number, so 5 chars) and we can use it not even in javascript, but directly in php to properly output the correct version.

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
…efore

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Spuds added a commit that referenced this pull request Nov 12, 2013
Admin js files - for discussion
@Spuds Spuds merged commit 496cc76 into elkarte:master Nov 12, 2013
@emanuele45 emanuele45 deleted the admin_js_files branch November 14, 2013 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants