Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] eww list-windows command that lists all existing window names #90

Closed
elkowar opened this issue Jan 7, 2021 · 3 comments
Closed

[FEATURE] eww list-windows command that lists all existing window names #90

elkowar opened this issue Jan 7, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@elkowar
Copy link
Owner

elkowar commented Jan 7, 2021

Description of the requested feature

The eww list-windows command should print out a simple, line-separated list listing all the window names that the user has configured.
This should work without the eww daemon, and should thus be implemented as an ActionClientOnly.
@elkowar elkowar added the enhancement New feature or request label Jan 7, 2021
@Barbaross93
Copy link

Perhaps this should be a separate issue, but in addition, when listing windows it should list which ones are currently drawn/visible. Would help make scripting easier. Thoughts?

@elkowar
Copy link
Owner Author

elkowar commented Jan 8, 2021

Sounds like a good feature to have in general, although I'm not sure if that would necessarily fit in here - as that would then require the eww daemon to be running. On the other hand, that wouldn't really be an issue i guess, so it may be a good idea. Thanks for the suggestion!

@elkowar
Copy link
Owner Author

elkowar commented Jan 16, 2021

I made the decision to not make this independent of the
daemon, as that makes it possible to provide more information, and
because in most cases, users will have the daemon running when checking windows anyways.

Now, a * is prepended to the window name in the eww windows output if the window is open.

elkowar added a commit that referenced this issue Jan 16, 2021
@elkowar
Add eww windows command and restructure daemon response.
8530f90 
Daemon response is now a dedicated type that contains information
about failure / success, and used in more commands, such as `open` and
`close`. Thus, this fixes #90 and also fixes #89.

For #90, the decision has been made to not make this independent of the
daemon, as that makes it possible to provide more information, and
because in most cases, users will have the daemon running when checking
windows anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elkowar @Barbaross93