Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a node and trying to navigate outside of it still warns about "Discard changes" #22

Closed
sheinbergon opened this issue Aug 28, 2018 · 8 comments
Labels

Comments

@sheinbergon
Copy link

After saving the node via the UI text editor clicking on the "home" icon or somewhere else in the node tree issues a warning about discarding unsaved values.

@elkozmon elkozmon added the bug label Oct 17, 2018
@elkozmon elkozmon added this to the 1.0.0 milestone Jan 8, 2019
@elkozmon elkozmon removed this from the 1.0.0 milestone Sep 18, 2019
@elkozmon
Copy link
Owner

elkozmon commented Feb 2, 2020

This seems to be fixed now.

@elkozmon elkozmon closed this as completed Feb 2, 2020
@Redirts
Copy link

Redirts commented Feb 3, 2020

No, it is not fixed.

2020-02-03_16-55-04

@elkozmon
Copy link
Owner

elkozmon commented Feb 3, 2020

@Redirts
Sorry, I failed to mention that I was talking about the latest builds (as in :latest Docker image) since commit bd31f1f. There is no stable release of those changes yet.

Which version were you using, please? You can figure that out by opening the menu in the top right corner and clicking Show session info. Thank you!

@Redirts
Copy link

Redirts commented Feb 3, 2020

ZooNavigator version: latest-83c7683fe661

@elkozmon
Copy link
Owner

elkozmon commented Feb 3, 2020 via email

@elkozmon
Copy link
Owner

elkozmon commented Feb 3, 2020

Turns out you're right, it's still an issue. I couldn't reproduce it locally on my computer for some reason. Anyway, I'm reopening this then. Sorry.

@elkozmon elkozmon reopened this Feb 3, 2020
@Redirts
Copy link

Redirts commented Feb 4, 2020

Seems ok now but will let you know if it breaks in another use case. Thanks

@elkozmon
Copy link
Owner

elkozmon commented Feb 4, 2020

@Redirts Happy to hear that. Sure, let me know. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants