-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion]: Fail loudly when trying to install on Django>=1.9 #36
Comments
@filwaitman I suggest you to try django-admin-interface, it is based on |
@fabiocaccamo thanks for the quick reply! I'm not sure if I made myself clear. My scenario is: What I got: What I'm suggesting: What do you think? |
@filwaitman I understood your scenario, I had your same problem while testing Here you can see how I solved it: https://github.com/fabiocaccamo/django-admin-interface/blob/master/admin_interface/settings.py |
@filwaitman a ha! So I misread your first comment. =P |
@filwaitman why you need to land a PR? it's already done... |
It's done for django-admin-interface, not for django-flat-theme, right? |
|
Yes but the problem is: I wasn't using django-admin-interface. I was using pure django-flat-theme. I upgraded django + another 50 third party libraries, it's a though work to look individually to each of them and check whether or not I should flip to another library at that point. I would love to simply upgrade django-flat-theme (again, nothing related to django-admin-interface at this point) and see it failing so I could see easily that this is "incompatible" (actually "no longer needed") for django>=1.9. This is not about "use library X, it suits your needs best". This is about upgrading a super old version of some third party library I decided to use 3-4 years ago. |
Send a PR and hope it will be merged. |
Hi there!
I was wondering if it would be nice force an installation error when Django>=1.9 is present.
This may (or may not, IDK) be a rare scenario but take my case as an example: I just upgraded a project from Django 1.8 to Django 1.11... and my Django admin interface was... well... misbehaving. It took me a considerable amount of time to understand that that was being caused by conflicts between (in my case) this and that.
If you guys agree this is a good idea I'll be happy to implement the changes, if needed.
The text was updated successfully, but these errors were encountered: