Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Secret for CF_TOKEN #3

Open
rubidot opened this issue Jan 29, 2018 · 2 comments
Open

Docker Secret for CF_TOKEN #3

rubidot opened this issue Jan 29, 2018 · 2 comments

Comments

@rubidot
Copy link

rubidot commented Jan 29, 2018

In your alpine-cloudflare-dyndns image, it would be great to have to option to use a docker secret instead of an environment variable for the CloudFlare API key.

Thanks for the image!

@rubidot
Copy link
Author

rubidot commented Jan 29, 2018

Actually, it might also be helpful to have CF_DOMAIN_NAME also setup to work with secrets

@ellerbrock
Copy link
Owner

hi @rubidot,

yes your right, since secrets are now available this makes sense.
can you make a pr for the change please?

cheers maik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant