Update control$df to control$power_df in simsum.R #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your great package. When applying it and comparing it to the results of my own code, I got different power/rejection-rates and checked your code. Your check of the control list seems to have a small error due to changes in names. Your checking if control$df is a number instead of control$power_df. This means that you cannot specify power_df at the moment. It's either set to the default NULL when you specify power_df in the control list or if you specify df it's returning an error for the name-control of the list.
Kaladani
changed the title
|
Thanks very much for your PR, good catch! |
ellessenne
added a commit
that referenced
this pull request
Jul 5, 2021
ellessenne
added a commit
that referenced
this pull request
Jul 5, 2021
|
I'm glad I could help. As an idea for the the next update (post 0.1.0) you might want to consider to allow to add a column of p-values by the user. This way, power could be calculated even if the model is using neither z- nor t-test. This might be particularly useful to allow for e.g. rejection rate of model fit and comparison tests. It would also align stronger to Morris et. a. 2019 definition of power/rejection estimation. |
|
Thanks for the suggestion, I'll definitely consider this for the next version of {rsimsum} – I opened a new issue (#35) if you want to keep track of it, or add specific examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your great package.
When applying it and comparing it to the results of my own code, I got different power/rejection-rates and checked your code. Your check of the control list seems to have a small error due to changes in names. Your checking if control$df is a number instead of control$power_df. This means that you cannot specify power_df at the moment. It's either set to the default NULL when you specify power_df in the control list or if you specify df it's returning an error for the name-control of the list.