Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove rebar_erl_vsn plugin and replace with OTP_RELEASE #73

Merged
merged 1 commit into from Feb 20, 2019
Merged

remove rebar_erl_vsn plugin and replace with OTP_RELEASE #73

merged 1 commit into from Feb 20, 2019

Conversation

tsloughter
Copy link
Member

This plugin will always get out of date and issue a warning. Since it doesn't appear to even be needed for what we were using it for I've removed it and replaced its use with the OTP_RELEASE macro that was added to otp.

@tsloughter tsloughter requested review from yurrriq and a team February 20, 2019 17:50
@yurrriq
Copy link
Member

yurrriq commented Feb 20, 2019

LGTM, thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.867% when pulling dd64067 on tsloughter:develop into c16ac7d on elli-lib:develop.

@tsloughter tsloughter merged commit b352766 into elli-lib:develop Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsloughter @yurrriq @coveralls