Change to use strings.TrimLeft instead of regexp #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was fooling around with parsing libxml2, and got this output |-TypedefDecl 0x7fd88090c5d8 <line:845:1, line:847:9> line:845:17 referenced xmlGenericErrorFunc 'void (*)(void *, const char *, ...)' | |-PointerType 0x7fd88090c570 'void (*)(void *, const char *, ...)' | | `-ParenType 0x7fd88090c510 'void (void *, const char *, ...)' sugar | | `-FunctionProtoType 0x7fd88090c4d0 'void (void *, const char *, ...)' cdecl | | |-BuiltinType 0x7fd88081c520 'void' | | |-PointerType 0x7fd88081c950 'void *' | | | `-BuiltinType 0x7fd88081c520 'void' | | |-PointerType 0x7fd88081cb90 'const char *' | | | `-QualType 0x7fd88081c561 'const char' const | | | `-BuiltinType 0x7fd88081c560 'char' | | `-... And c2go choked on the last line, saying panic: Cannot understand line '| | `-...' In this case the prefix matches, but the dots don't match against \w, so this line fails. Anyway, using regular expression with this particular pattern seems overkill, so it has been changed to strings.TrimLeft
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 71.31% 71.33% +0.01%
==========================================
Files 126 126
Lines 4459 4455 -4
==========================================
- Hits 3180 3178 -2
+ Misses 1141 1140 -1
+ Partials 138 137 -1
Continue to review full report at Codecov.
|
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was fooling around with parsing libxml2, and got this output
And c2go choked on the last line, saying
In this case the prefix matches, but the dots don't match against \w, so
this line fails.
Anyway, using regular expression with this particular pattern seems
overkill, so it has been changed to strings.TrimLeft
This change is