Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temporary folder for file pp.c. Fixes #244 #247

Merged
merged 1 commit into from Oct 17, 2017
Merged

Use temporary folder for file pp.c. Fixes #244 #247

merged 1 commit into from Oct 17, 2017

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Oct 17, 2017

See #244


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

Merging #247 into master will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   80.79%   80.77%   -0.03%     
==========================================
  Files         134      134              
  Lines        5328     5332       +4     
==========================================
+ Hits         4305     4307       +2     
- Misses        834      835       +1     
- Partials      189      190       +1
Impacted Files Coverage Δ
main.go 52.6% <60%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3ffc7...5711bd8. Read the comment docs.

@elliotchance elliotchance changed the title add temp folder for file pp.c Use temporary folder for file pp.c. Fixes #244 Oct 17, 2017
@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 953a59f into elliotchance:master Oct 17, 2017
@Konstantin8105 Konstantin8105 deleted the parallel branch October 19, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants