Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineCommandComment. Fix #553 #554

Merged
merged 13 commits into from Jan 14, 2018
Merged

InlineCommandComment. Fix #553 #554

merged 13 commits into from Jan 14, 2018

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Jan 11, 2018

Close #553


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #554 into master will decrease coverage by 0.07%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   80.46%   80.39%   -0.08%     
==========================================
  Files         156      157       +1     
  Lines        7460     7482      +22     
==========================================
+ Hits         6003     6015      +12     
- Misses       1126     1136      +10     
  Partials      331      331
Impacted Files Coverage Δ
ast/full_comment.go 88.23% <ø> (ø) ⬆️
ast/verbatim_line_comment.go 55.55% <ø> (ø) ⬆️
ast/paragraph_comment.go 88.23% <ø> (ø) ⬆️
ast/html_start_tag_comment.go 55.55% <ø> (ø) ⬆️
ast/block_command_comment.go 55.55% <ø> (ø) ⬆️
ast/param_command_comment.go 55.55% <ø> (ø) ⬆️
ast/text_comment.go 77.77% <ø> (ø) ⬆️
ast/html_end_tag_comment.go 55.55% <ø> (ø) ⬆️
ast/position.go 80.06% <0%> (-0.55%) ⬇️
ast/ast.go 98.22% <100%> (+0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ff9a0...2e7608e. Read the comment docs.

@elliotchance elliotchance changed the title InlineCommandComment. Fix#553 InlineCommandComment. Fix #553 Jan 14, 2018
@elliotchance
Copy link
Owner

Reviewed 3 of 4 files at r1, 9 of 9 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


ast/text_comment.go, line 3 at r2 (raw file):

package ast

// TextComment is a type of comment

Thanks for putting all of these comment in.


Comments from Reviewable

@elliotchance elliotchance merged commit 375c8da into elliotchance:master Jan 14, 2018
@Konstantin8105 Konstantin8105 deleted the AstCom1 branch January 16, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants