Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for some time.h functions and structures. Fixes #592 #593

Merged
merged 86 commits into from Feb 9, 2018
Merged

Added support for some time.h functions and structures. Fixes #592 #593

merged 86 commits into from Feb 9, 2018

Conversation

Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented Jan 26, 2018

Close #592


This change is Reviewable

@elliotchance elliotchance changed the title Mktime. Fix #592 Mktime. Fixes #592 Jan 26, 2018
@elliotchance
Copy link
Owner

Please merge or rebase master so the diff is smaller.


Review status: 0 of 112 files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks broke.


noarch/time.go, line 69 at r1 (raw file):

// Uses the value pointed by timer to fill a tm structure with the values that
// represent the corresponding time, expressed for the local timezone.
func LocalTime(timer []TimeT) (tm []Tm) {

👍


tests/time.c, line 64 at r1 (raw file):

  is_eq(timeinfo->tm_wday,5);
}
*/

Why was this disabled?


tests/time.c, line 71 at r1 (raw file):

    START_TEST(time);
    START_TEST(ctime);

Also missing START_TEST(mktime);


Comments from Reviewable

@Konstantin8105
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks broke.


noarch/time.go, line 69 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

👍

Ok ).


tests/time.c, line 64 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

Why was this disabled?

It is not easy to test mktime


tests/time.c, line 71 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

Also missing START_TEST(mktime);

Add some test


Comments from Reviewable

@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #593 into master will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   80.28%   80.26%   -0.03%     
==========================================
  Files         158      158              
  Lines        7935     7975      +40     
==========================================
+ Hits         6371     6401      +30     
- Misses       1202     1213      +11     
+ Partials      362      361       -1
Impacted Files Coverage Δ
program/function_definition.go 100% <ø> (ø) ⬆️
transpiler/variables.go 80.86% <100%> (+0.25%) ⬆️
types/resolve.go 83.58% <100%> (+0.99%) ⬆️
noarch/time.go 64.15% <67.56%> (+7.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc58f69...36e3f8d. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 6 of 6 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance elliotchance changed the title Mktime. Fixes #592 Added support for some time.h functions and structures. Fixes #592 Feb 9, 2018
@elliotchance elliotchance merged commit 0519754 into elliotchance:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants