New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for some time.h functions and structures. Fixes #592 #593
Conversation
Please merge or rebase master so the diff is smaller. Review status: 0 of 112 files reviewed at latest revision, all discussions resolved, some commit checks broke. Comments from Reviewable |
Reviewed 5 of 5 files at r1. noarch/time.go, line 69 at r1 (raw file):
👍 tests/time.c, line 64 at r1 (raw file):
Why was this disabled? tests/time.c, line 71 at r1 (raw file):
Also missing Comments from Reviewable |
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks broke. noarch/time.go, line 69 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Ok ). tests/time.c, line 64 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
It is not easy to test tests/time.c, line 71 at r1 (raw file): Previously, elliotchance (Elliot Chance) wrote…
Add some test Comments from Reviewable |
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 80.28% 80.26% -0.03%
==========================================
Files 158 158
Lines 7935 7975 +40
==========================================
+ Hits 6371 6401 +30
- Misses 1202 1213 +11
+ Partials 362 361 -1
Continue to review full report at Codecov.
|
Reviewed 6 of 6 files at r2. Comments from Reviewable |
Close #592
This change is