Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try parsing for all lines of muli-line character literal. Fixes #675 #676

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Apr 16, 2018

Fixes #675


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #676 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   82.17%   82.18%   +0.01%     
==========================================
  Files         164      164              
  Lines        8834     8841       +7     
==========================================
+ Hits         7259     7266       +7     
  Misses       1178     1178              
  Partials      397      397
Impacted Files Coverage Δ
ast/character_literal.go 94.59% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c08ad...8d7ed4c. Read the comment docs.

@kamphaus kamphaus force-pushed the fix-675-parse-multiline-character-literal branch from 6d0310c to 8d7ed4c Compare April 24, 2018 13:37
@elliotchance
Copy link
Owner

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit a95ff5d into elliotchance:master Apr 26, 2018
@kamphaus kamphaus deleted the fix-675-parse-multiline-character-literal branch April 26, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants