Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not limit number of go build errors for integration tests. Fixes #690 #691

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Apr 27, 2018

Fixes #690


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         164      164           
  Lines        8875     8875           
=======================================
  Hits         7265     7265           
  Misses       1208     1208           
  Partials      402      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f403df...c0d0cae. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit fe521e6 into elliotchance:master Apr 30, 2018
@kamphaus kamphaus deleted the fix-690-total-number-of-build-errors branch April 30, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants