Improved double equal handling. Fixes #565 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atomic operands can be transpiled as statements when already wrapped in an anonymous function, i.e. no need to double wrap them.
Do not show deferred statement when the list of deferred statements is empty, but not nil
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 81.86% 81.88% +0.02%
==========================================
Files 164 164
Lines 8937 8955 +18
==========================================
+ Hits 7316 7333 +17
- Misses 1219 1220 +1
Partials 402 402
Continue to review full report at Codecov.
|
|
Nice! 👍 Reviewed 7 of 8 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved wrapping in anonymous function of assignish operators when in an atomic expression.
This handles problems like use in switch/for expressions, with implicit cast.
Fixes #565
This change is