Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast uintptr difference to correct type. Fixes #704 #705

Merged
merged 2 commits into from
May 6, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 4, 2018

Fixes #704


This change is Reviewable

@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         164      164           
  Lines        8983     8983           
=======================================
  Hits         7361     7361           
  Misses       1220     1220           
  Partials      402      402
Impacted Files Coverage Δ
util/goast.go 88.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b5721...5119066. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 2b346c3 into elliotchance:master May 6, 2018
@kamphaus kamphaus deleted the fix-704-cast-uintptr branch May 6, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants