Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer arithmetic for negative array index. Fixes #708 #709

Merged

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 4, 2018

Fixes #708


This change is Reviewable

@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #709 into master will decrease coverage by 0.33%.
The diff coverage is 53.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage      82%   81.66%   -0.34%     
==========================================
  Files         164      165       +1     
  Lines        9042     9164     +122     
==========================================
+ Hits         7415     7484      +69     
- Misses       1223     1270      +47     
- Partials      404      410       +6
Impacted Files Coverage Δ
transpiler/variables.go 83.92% <100%> (+0.38%) ⬆️
transpiler/unary.go 71.45% <43.18%> (-3.11%) ⬇️
util/evaluate.go 55.55% <55.55%> (ø)
noarch/string.go 100% <0%> (ø) ⬆️
program/function_definition.go 100% <0%> (ø) ⬆️
ast/weak_attr.go 55.55% <0%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee818b...69dd26c. Read the comment docs.

@kamphaus kamphaus force-pushed the fix-708-negative-array-index branch from b4f2972 to 57df606 Compare May 4, 2018 13:11
@elliotchance
Copy link
Owner

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@kamphaus kamphaus force-pushed the fix-708-negative-array-index branch from 57df606 to d243cf8 Compare May 6, 2018 09:01
@elliotchance
Copy link
Owner

Reviewed 1 of 2 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance elliotchance merged commit c081600 into elliotchance:master May 7, 2018
@kamphaus kamphaus deleted the fix-708-negative-array-index branch May 8, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants