Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on WeakAttr. Fixes #610 #712

Merged
merged 1 commit into from
May 6, 2018
Merged

Fix panic on WeakAttr. Fixes #610 #712

merged 1 commit into from
May 6, 2018

Conversation

elliotchance
Copy link
Owner

@elliotchance elliotchance commented May 6, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented May 6, 2018

Codecov Report

Merging #712 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   81.95%   81.92%   -0.03%     
==========================================
  Files         164      164              
  Lines        9016     9156     +140     
==========================================
+ Hits         7389     7501     +112     
- Misses       1223     1239      +16     
- Partials      404      416      +12
Impacted Files Coverage Δ
ast/weak_attr.go 55.55% <100%> (+2.61%) ⬆️
types/cast.go 68.09% <0%> (+0.56%) ⬆️
transpiler/binary.go 74.21% <0%> (+4.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33840eb...4f99007. Read the comment docs.

@elliotchance
Copy link
Owner Author

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 1d41ef0 into master May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant