Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take address of complex expressions. Fixes #715 #716

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 7, 2018

Fixes #715


This change is Reviewable

@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #716 into master will increase coverage by 0.03%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   82.03%   82.07%   +0.03%     
==========================================
  Files         164      164              
  Lines        9057     9086      +29     
==========================================
+ Hits         7430     7457      +27     
- Misses       1223     1224       +1     
- Partials      404      405       +1
Impacted Files Coverage Δ
transpiler/operators.go 78.4% <100%> (+0.38%) ⬆️
util/goast.go 88.71% <93.33%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071d3ea...5e5ad83. Read the comment docs.

@kamphaus kamphaus force-pushed the fix-715-take-address-of-complex-expr branch from 7cf2417 to 5e5ad83 Compare May 7, 2018 20:16
@elliotchance
Copy link
Owner

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 27d1cee into elliotchance:master May 7, 2018
@kamphaus kamphaus deleted the fix-715-take-address-of-complex-expr branch May 8, 2018 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants