Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use temp variable for atomic assign. Fixes #744 #745

Merged
merged 2 commits into from Jun 17, 2018
Merged

Use temp variable for atomic assign. Fixes #744 #745

merged 2 commits into from Jun 17, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Jun 12, 2018 •
edited by elliotchance

Fixes #744

This change is Reviewable

@kamphaus
Copy link
Contributor Author

A possible optimization is to only use a tempVar if the type of the left hand side is a pointer and the result is not.
The previous code (without tempVar) should work fine for if the LHS is not a pointer.

@elliotchance
Copy link
Owner

Reviewed 3 of 3 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable

@elliotchance elliotchance merged commit 5daf485 into elliotchance:master Jun 17, 2018
@kamphaus kamphaus deleted the fix-744-correctincrement branch June 18, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamphaus @elliotchance @christophe-kamphaus-jemmic