Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract methods throw exception on nice mocks #158

Merged
merged 5 commits into from Sep 11, 2014
Merged

Abstract methods throw exception on nice mocks #158

merged 5 commits into from Sep 11, 2014

Conversation

elliotchance
Copy link
Owner

When creating a nice mock, any abstract methods will throw the exception:

getId() does not have an associated action - consider a niceMock()?

Which isn't true, they should have the exception message explaining that they are abstract.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 65f5a00 on 1.3.3/158-function-for-with into d1a51bc on release/1.3.3.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 65f5a00 on 1.3.3/158-function-for-with into d1a51bc on release/1.3.3.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

elliotchance added a commit that referenced this pull request Sep 11, 2014
@elliotchance
Merge pull request #158 from elliotchance/1.3.3/158-function-for-with
f7abbb5 
Abstract methods throw exception on nice mocks
@elliotchance elliotchance merged commit f7abbb5 into release/1.3.3 Sep 11, 2014
@elliotchance elliotchance deleted the 1.3.3/158-function-for-with branch September 11, 2014 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Mocking Size: 1 (Small) Type: Bug
Projects
None yet
Milestone
v1.3.3 (Supernova, Patch 3)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elliotchance @coveralls @scrutinizer-notifier