Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error using with() and single quotes #248

Merged
merged 1 commit into from Mar 12, 2015

Conversation

elliotchance
Copy link
Owner

        $select = $this->mock('\CDbCommand')
            ->disableConstructor()
            ->expect('join')->with('producttags', 'producttags.productid = products.productid')
            ->expect('andWhere')->with("lower(tagname) IN ('foo', bar)")
            ->stub(['getConnection' => DBManager::masterConnection()])
            ->get();
Argument 1 passed to Concise\Mock\ArgumentMatcher::match() must be of the type array, null given, called in /mnt/hgfs/git/kounta/vendor/elliotchance/concise/src/Concise/Mock/ClassCompiler.php(370) : eval()'d code on line 123 and defined

Changing to:

            ->expect('andWhere')->with("lower(tagname) IN (foo, bar)")

Works as expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b660c47 on 1.7.2/248-with-single-quotes into f190440 on release/1.7.2.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

elliotchance added a commit that referenced this pull request Mar 12, 2015
Compilation error using with() and single quotes
@elliotchance elliotchance merged commit d5a4b29 into release/1.7.2 Mar 12, 2015
@elliotchance elliotchance deleted the 1.7.2/248-with-single-quotes branch March 12, 2015 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants