Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 7 #328

Merged
merged 4 commits into from Jun 4, 2017
Merged

Add support for PHP 7 #328

merged 4 commits into from Jun 4, 2017

Conversation

elliotchance
Copy link
Owner

Review on Reviewable

@elliotchance
Copy link
Owner Author

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@ostrolucky
Copy link

@elliotchance Is PHP7 support still missing? I wanted to try concise since it looks interesting, but I'm not going to do even that since this project looks pretty much dead :( Is there a recommended alternative? Maybe https://github.com/atoum/atoum?

@elliotchance
Copy link
Owner Author

Hi @ostrolucky - it's true I haven't put any new features into concise for a while. But it's still heavily used by the company I work for. We simply haven't upgraded to PHP7 yet.

I have a feeling I know why those couple of tests are failing, I'll investigate now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 99.668% when pulling 07dd5c6 on 2.2.0/328-php7 into bdea3b1 on release/2.2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 99.668% when pulling 746e486 on 2.2.0/328-php7 into facad98 on release/2.2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 99.668% when pulling 746e486 on 2.2.0/328-php7 into facad98 on release/2.2.0.

@elliotchance elliotchance changed the base branch from release/2.2.0 to release/2.1.2 June 4, 2017 08:54
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8fd1d4d on 2.2.0/328-php7 into 445c820 on release/2.1.2.

@elliotchance
Copy link
Owner Author

Reviewed 1 of 1 files at r2, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit dc19cdb into release/2.1.2 Jun 4, 2017
@elliotchance elliotchance deleted the 2.2.0/328-php7 branch June 4, 2017 09:05
@elliotchance
Copy link
Owner Author

@ostrolucky this has been merged and released as v2.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants