Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ghost checker #160

Merged
merged 1 commit into from Oct 16, 2018
Merged

Adding ghost checker #160

merged 1 commit into from Oct 16, 2018

Conversation

elliotchance
Copy link
Owner

@elliotchance elliotchance commented Oct 7, 2018

A bit of refactoring to enforce the default max line complexity of 5. This should be improved further in the future.


This change is Reviewable

@elliotchance elliotchance added this to In progress in gedcom via automation Oct 7, 2018
@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #160 into master will increase coverage by 1.17%.
The diff coverage is 56.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   41.37%   42.55%   +1.17%     
==========================================
  Files         135      138       +3     
  Lines        3705     3887     +182     
==========================================
+ Hits         1533     1654     +121     
- Misses       2147     2207      +60     
- Partials       25       26       +1
Impacted Files Coverage Δ
dater.go 100% <ø> (ø) ⬆️
gedcom2html/main.go 0% <ø> (ø) ⬆️
gedcomdiff/main.go 0% <0%> (ø) ⬆️
html/table_cell.go 0% <0%> (ø) ⬆️
html/line_break.go 0% <0%> (ø)
gedcom2html/source_link.go 0% <0%> (ø) ⬆️
gedcom2html/family_statistics.go 0% <0%> (ø) ⬆️
html/table.go 0% <0%> (ø) ⬆️
gedcomdiff/individual_compare.go 0% <0%> (ø) ⬆️
gedcom2html/util.go 0% <0%> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e240b...95146d5. Read the comment docs.

A bit of refactoring to enforce the default max line complexity of 2.
@elliotchance elliotchance merged commit e4af4e7 into master Oct 16, 2018
gedcom automation moved this from In progress to Done Oct 16, 2018
@elliotchance elliotchance deleted the ghost branch October 16, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
gedcom
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants