Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Interface" to compiled JSON #119

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Add "Interface" to compiled JSON #119

merged 1 commit into from
Dec 25, 2020

Conversation

elliotchance
Copy link
Owner

@elliotchance elliotchance commented Dec 24, 2020

The interface is necessary for later when I removed the PackageFunc.
Also, allowed me to do some cleanup.


This change is Reviewable

The interface is necessary for later when I removed the PackageFunc.
Also, allowed me to do some cleanup.
@codecov-io
Copy link

Codecov Report

Merging #119 (25425ed) into master (b711fc1) will increase coverage by 0.04%.
The diff coverage is 91.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   89.37%   89.42%   +0.04%     
==========================================
  Files         183      182       -1     
  Lines       17340    17440     +100     
==========================================
+ Hits        15498    15595      +97     
- Misses       1703     1706       +3     
  Partials      139      139              
Impacted Files Coverage Δ
types/type.go 63.63% <0.00%> (-15.61%) ⬇️
vm/interface.go 0.00% <0.00%> (ø)
vm/okc.go 0.00% <0.00%> (ø)
vm/symbol.go 0.00% <ø> (ø)
vm/lib.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b711fc1...25425ed. Read the comment docs.

@elliotchance elliotchance merged commit 5303698 into master Dec 25, 2020
@elliotchance elliotchance deleted the interface-in-json branch December 25, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants