Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the testify dependency #3

Open
elliotchance opened this issue Aug 7, 2018 · 4 comments
Open

Remove the testify dependency #3

elliotchance opened this issue Aug 7, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@elliotchance
Copy link
Owner

testify is great, but tf doesn't really need have it as a dependency. Instead just use the build in reflect.DeepEqual, as testify does.
@elliotchance elliotchance added the enhancement New feature or request label Aug 7, 2018
@dnephin
Copy link

dnephin commented Aug 8, 2018

stretchr/testify#535 seems relevant. Might want to use https://github.com/google/go-cmp instead. It worked well for me.

@elliotchance
Copy link
Owner Author

Yes, that's a great idea! Fancy putting in a PR? 😄

@m1ome
Copy link
Contributor

m1ome commented Sep 13, 2018

Will jump over it after merging #10 😄

@m1ome
Copy link
Contributor

m1ome commented Sep 14, 2018

Now after merging #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dnephin @elliotchance @m1ome