Add tsconfig.json support to tsc plugin
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although I would love if the ecosystem was as mature for
non-`tsconfig.json` projects compared to `tsconfig.json` projects, this
just isn't the case:
* VSCode works much better with a local `tsconfig.json` file (e.g. it
complains about `replaceAll` not being a method because we haven't
set the correct `lib`)
* There is a maximum line length for `cmd` (8191) that can be quite
limiting when passing a large number of files via the command line
* There are certain `tsconfig.json` options that cannot be passed via
the command line (e.g. `paths`)
* Existing users will most likely have a `tsconfig.json` file and it
is simpler for them to migrate to `ninjutsu-build` if they can reuse
this
* There are other tools, such as TypeDoc, that only work with a
`tsconfig.json` file
This commit adds support for a `tsconfig.json` file in the `makeTSCRule`
and `makeTypeCheckRule`.
Right now I am unsure whether to overload the `makeTSCRule` and
`makeTypeCheckRule` or rename the existing ones to `makeTSCRuleNoConfig`
and `makeTypeCheckRuleNoConfig` simplify the return types.
I will test this change out in building `ninjutsu` itself and
reevaluate.
elliotgoodrich
force-pushed
the
support-tsconfig
branch
from
1784b73
to
528f336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I would love if the ecosystem was as mature for non-
tsconfig.jsonprojects compared totsconfig.jsonprojects, this just isn't the case:tsconfig.jsonfile (e.g. it complains aboutreplaceAllnot being a method because we haven't set the correctlib)cmd(8191) that can be quite limiting when passing a large number of files via the command linetsconfig.jsonoptions that cannot be passed via the command line (e.g.paths)tsconfig.jsonfile and it is simpler for them to migrate toninjutsu-buildif they can reuse thistsconfig.jsonfileThis commit adds support for a
tsconfig.jsonfile in themakeTSCRuleandmakeTypeCheckRule.Right now I am unsure whether to overload the
makeTSCRuleandmakeTypeCheckRuleor rename the existing ones tomakeTSCRuleNoConfigandmakeTypeCheckRuleNoConfigsimplify the return types.I will test this change out in building
ninjutsuitself and reevaluate.