Allow extends property in tsconfig.json files
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tsc` supports `tsconfig.json` files having an `extends` property, which references another JSON file that can contain additional properties that will be used. Update `parseOutput.mts` to output the list of config files as part of the `dyndep` file so we will re-typecheck/transpile whenever the config file is updated. Note that is is not perfect - it will break if you change any option that controls the number or paths of the output files, or you add/remove additional files in `extends`. However, if you are changing warning levels or anything to do with typechecking it should work well. Additionally, use the parser inside `typescript` instead of `JSON.parse` as the format is `jsonc` (JSON with comments) and not pure JSON.
elliotgoodrich
force-pushed
the
allow-extends-in-tsc
branch
from
d121975
to
bbbe045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tscsupportstsconfig.jsonfiles having anextendsproperty, which references another JSON file that can contain additional properties that will be used.Update
parseOutput.mtsto output the list of config files as part of thedyndepfile so we will re-typecheck/transpile whenever the config file is updated. Note that is is not perfect - it will break if you change any option that controls the number or paths of the output files, or you add/remove additional files inextends. However, if you are changing warning levels or anything to do with typechecking it should work well.Additionally, use the parser inside
typescriptinstead ofJSON.parseas the format isjsonc(JSON with comments) and not pure JSON.