Fix calculateMidpoint #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed and completed calculateMidpoint(), so it returns correct result as [ lat, lon ] Array, so it won't be confused with full-blown GpxWaypoint {lat: lat, lon: lon} Object
2. Added optional inMiles parameter to calculateDistance(). Great Circle in miles is there for a reason, I guess :)
|
Sorry its been a while - Ive been off doing other things. Cheers for this! Ill take a look and get this merged in asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and completed calculateMidpoint(), so it returns correct result as [ lat, lon ] Array. I think its better than {lat: lat, lon: lon}, which can be confused with full-blown GpxWaypoint Object
Added optional inMiles parameter to calculateDistance(). Great Circle in miles is there for a reason, I guess :)