changing order at UnloadEffect, remove pointer from data structure fi…

…rst, then delete. This prevents the structure from holding an invalid pointer
elliotwoods · Jun 12, 2012 · a97746e · a97746e
1 parent 6bcbbe8
commit a97746e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/addons/ofxiPhone/src/SoundEngine.cpp b/addons/ofxiPhone/src/SoundEngine.cpp
@@ -1083,12 +1083,11 @@ class OpenALObject
 
 		OSStatus UnloadEffect(UInt32 inEffectID)
 		{
-			// [FIXED] SoundEngineEffect should be deleted before remove from the map
-			SoundEngineEffect *theEffect = mEffectsMap->Get(inEffectID);
+			mEffectsMap->Remove(inEffectID); //remove pointer from structure first
+			SoundEngineEffect *theEffect = mEffectsMap->Get(inEffectID); //then delete
 			if (theEffect){
 				delete theEffect;
 			}
-			mEffectsMap->Remove(inEffectID);
 			return 0;
 		}