Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open glow when not in path #44

Closed
jordanisaacs opened this issue Sep 30, 2021 · 2 comments · Fixed by #45
Closed

Open glow when not in path #44

jordanisaacs opened this issue Sep 30, 2021 · 2 comments · Fixed by #45

Comments

@jordanisaacs
Copy link

I would like to have :Glow work even when glow is not in my path but it exists in g:glow_binary_path. Currently it opens the terminal up and says command not found. I believe it could be fixed by changing

vim.fn.termopen(string.format("glow %s", vim.fn.shellescape(path)))
line to vim.fn.termopen(string.format("%s/glow %s", bin_path, vim.fn.shellescape(path)))

@ellisonleao
Copy link
Owner

good catch! will fix it ASAP

@ashishbinu
Copy link
Contributor

@ellisonleao I have added a PR for the above issue.

ellisonleao pushed a commit that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants