Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS not supported #82

Closed
mengano-net opened this issue Aug 1, 2022 · 6 comments
Closed

OS not supported #82

mengano-net opened this issue Aug 1, 2022 · 6 comments

Comments

@mengano-net
Copy link
Contributor

mengano-net commented Aug 1, 2022

Hi:

Great plugin by the way, thanks for your efforts.

I upgraded nvim at some point in the recent past, now :Glow won't run, I'm not sure what changed, here is my config:

  • nvim version
❯ nvim --version
NVIM v0.8.0-dev+555-gd07a39c54
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/Users/runner/work/neovim/neovim/build/cmake.config -I/Users/runner/work/neovim/neovim/src -I/Users/runner/work/neovim/neovim/.deps/usr/include -I/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include -I/Library/Frameworks/Mono.framework/Headers -I/Users/runner/work/neovim/neovim/build/src/nvim/auto -I/Users/runner/work/neovim/neovim/build/include
Compiled by runner@Mac-1656995109108.local

Features: +acl +iconv +tui
See ":help feature-compile"
  • macOS Monterry 12.5
  • :lua print(vim.loop.os_uname().sysname) = "Darwin"
  • I use wbthomason/packer.nvim to manage my plugins, this is my :Glow snippet:
  use({
    "ellisonleao/glow.nvim",
    branch = "main",
    config = {
      function()
        require("glow").setup({
          border = "rounded",
          width = 100,
        })
      end,
    },
  })
@mengano-net
Copy link
Contributor Author

More details that will hopefully aid troubleshooting

❯ .local/bin/glow --version
glow version 1.4.1 (4863f57)
❯ .local/bin/glow test.md

  This is a test

  test

  italics

  This is a test that I'm writing to see if this dam thing gets wrapped automatically, in fact I'm checking several
  things here.

  This is yet another paragraph that I'm writing to check this thing or this other thing and figure out wrapping

   Header

  ## HEADER 2

    testing

  This is another test that I'm writing in order to test this  GoYo plugin . To be honest, I'm not sure about it

  Does this mean that a new line starts after having a single space left? Nah, that can't be


~
❯```

@Ghasak
Copy link

Ghasak commented Aug 3, 2022

Hi @mengano-net
I have added a pull request
HotFix
I have used the as you suggested vim.loop.os_uname().sysname
instead jit.os
You can achieve temporarily until get approved the same at
~/.local/share/nvim/site/pack/packer/start/glow.nvim/lua/glow
Simply by changing the line
local raw_os = jit.os
to
local raw_os = vim.loop.os_uname().sysname
I hope this is useful

@ellisonleao
Copy link
Owner

@Ghasak and @mengano-net can you guys show the output for:

:lua vim.pretty_print(jit.os)

not sure why that env is not working for your OS/arch

@mengano-net
Copy link
Contributor Author

@Ghasak and @mengano-net can you guys show the output for:

:lua vim.pretty_print(jit.os)

not sure why that env is not working for your OS/arch

"OSX"

@mengano-net
Copy link
Contributor Author

Confirmed fix worked, thanks all.

@Ghasak
Copy link

Ghasak commented Aug 9, 2022

Hi @ellisonleao and @mengano-net
Yes, same for me,
the output of jit.os is OSX not Darwin

ellisonleao pushed a commit that referenced this issue Aug 23, 2022
* fix!(macos): fixing raw_os.

See isse: #82

BREAKING CHANGE

Signed-off-by: Alex Rodriguez <arodriguez@bluebeam.com>

* fix(arm64 arch): fix for print(jit.arch) = arm64

Signed-off-by: Mengano.net <28873858+mengano-net@users.noreply.github.com>

* feat(win_size): increasing win size

Signed-off-by: Mengano.net <28873858+mengano-net@users.noreply.github.com>

* feat(win size): moving it to the right a bit

Signed-off-by: Mengano.net <28873858+mengano-net@users.noreply.github.com>

* feat(win size): hardcoding width to 0.9

Signed-off-by: Mengano.net <28873858+mengano-net@users.noreply.github.com>

* debug: adding printing infor for debug

Signed-off-by: Mengano.Net <28873858+mengano-net@users.noreply.github.com>

* revert(win_height): back to 0.7, removed debug code.

Signed-off-by: Mengano.net <28873858+mengano-net@users.noreply.github.com>

Signed-off-by: Alex Rodriguez <arodriguez@bluebeam.com>
Signed-off-by: Mengano.net <28873858+mengano-net@users.noreply.github.com>
Signed-off-by: Mengano.Net <28873858+mengano-net@users.noreply.github.com>
Co-authored-by: Alex Rodriguez <arodriguez@bluebeam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants