BREAKING CHANGE: gruvbox is now a single module #280
Merged
+287
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palette: Can now be accessed in the main module through `require('gruvbox').palette`
get_base_colors: now a internal function called get_colors. If you want
to get the colors, just get the palette directly
groups: now moved to main module
polyzen
reviewed
Oct 1, 2023
|
|
||
| ```lua | ||
| { "ellisonleao/gruvbox.nvim", priority = 1000 } | ||
| { "ellisonleao/gruvbox.nvim", priority = 1000 , setup = true, opts = ...} |
There was a problem hiding this comment.
There doesn't seem to be a setup property, seems you meant to use config instead. Also that would be unnecessary as setting opts "will imply Plugin.config()".
There was a problem hiding this comment.
@polyzen actualy it's a typo, using config with opts will basically call require('gruvbox').setup(opts). Will fix it
ambroisie
added a commit
to ambroisie/nix-config
that referenced
this pull request
Oct 26, 2023
I dislike the new style of diff [1]. After somebody wrote a patch [2] I finally started experimenting with what looked best to me. This is using the old vibrant colours, which I like better. And avoids using `reverse = true` to not break high-lighting during visual selection. This is using an overlay as it is _much_ easier to refer to the internal colours in a `dark`/`light` agnostic way that way instead of the intended "use the palette way" (due to breaking changes in [3] which, incidentally, is the MR which changed diff high-lighting). [1]: ellisonleao/gruvbox.nvim#290 [2]: ellisonleao/gruvbox.nvim#291 [3]: ellisonleao/gruvbox.nvim#280
|
It's kind of annoying to have to use |
|
Moreover user has to deal not only with light/dark but also with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
palette: Can now be accessed in the main module through
require('gruvbox').paletteget_base_colors: now a internal function called get_colors. If you want to get the colors, just get the palette directly
groups: now moved to main module
diffs: fixing diff highlights for multiple plugins