Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sharer object pointing invalid construtor property #34

Closed
wants to merge 3 commits into from
Closed

Fix: Sharer object pointing invalid construtor property #34

wants to merge 3 commits into from

Conversation

m-sureshraj
Copy link

Sharer object pointing invalid constructor property.

Sharer.prototype = {...};
will override the sharer obj default constructor (Sharer) property to (Object)

console.log(Sharer.constructor === Sharer); //false
console.log(Sharer.constructor === Object); //true

Manually set the constructor property
Sharer.prototype = {constructor: Sharer, ....}

console.log(Sharer.constructor === Sharer); //true

done..

@ellisonleao
Copy link
Owner

Can you remove the minification changes? i can do it myself.

@m-sureshraj
Copy link
Author

Sorry... i didn't get that. Minification change mean...? Can u tell me more about that..

@ellisonleao
Copy link
Owner

there is a change on the sharer.min.js file . Can you please remove that change and just leave the sharer.js file change?

@m-sureshraj
Copy link
Author

Yes sure..

@m-sureshraj
Copy link
Author

Really sorry @ellisonleao, i couldn't remove the minification changes. Pls close this PR.
You can manually add this code " Sharer.prototype = {constructor: Sharer, ....} in to sharer.js file.
sorry for your inconvenience and time. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants