-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time_series_intraday_extended #30
Add time_series_intraday_extended #30
Conversation
@RocketRoss Do the tests pass when you run locally? |
I believe so.. All of the pre-existing tests pass, except in cases where my free API limit has been reached:
|
Ok great, just add your test function (even if it fails) and I'll deal with the API limits |
Issue was that the extended function doesn't seem to take kindly to |
Tests don't pass because of too many calls to the API. I was playing around with If the tests pass for one of the jobs in the matrix then it is probably good to go. |
The new tests passed in some of the jobs, so I've merged. |
The failed tests seem to be related to Julia's version. Perhaps the new function's use of some regex to validate arguments is enabled by recent developments in Julia. |
I duplicated and modified time_series_intraday to provide access to the EXTENDED function.
TODO is add to the test suite. Simple inclusion in the existing time_series tests resulted in failures.