Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow types so we no longer have Vector{Any} #40

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

pdeffebach
Copy link
Contributor

Currently, if you call DataFrame on an AlphaVantageResponse object, you get a bunch of columns with eltype Any. This is kind of annoying, since each column really has the same type.

This fix here is a "quick fix", since we still allocate a Matrix{Any} at some point. But I don't want to add CSV.jl as a dependency. Not sure what the best strategy is long term.

@pdeffebach
Copy link
Contributor Author

@ellisvalentiner can you confirm if test failures are part of this PR or unrelated?

@ellisvalentiner
Copy link
Owner

@pdeffebach thanks for the contribution

I think the test failures are due to how Github Actions handle secrets for forked pull requests.

@pdeffebach
Copy link
Contributor Author

Okay let me add more tests.

Once the tests are added, and docs, we can merge this and think about how to get around readdlm issues in a future PR.

@ellisvalentiner
Copy link
Owner

@pdeffebach thanks, can you also bump the version number?

@dm13450 dm13450 merged commit 29d6b0c into ellisvalentiner:master Sep 30, 2021
@pdeffebach
Copy link
Contributor Author

Thank you! Sorry for not following up with this.

@dm13450
Copy link
Collaborator

dm13450 commented Sep 30, 2021

No worries, thanks for doing the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants