__unicode__ added to BBCodeContent class #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this pull request! Could you make this change before merging ? |
|
I did what you said (replaced unicode with str and added python_2_unicode_compatible decorator). I am kind of new to all this contributing and pull requests stuff. Did I understand correctly that after necessary changes I should just add another commit, push it to github and that's all? |
ellmetha
added a commit
that referenced
this pull request
Jul 26, 2014
__unicode__ added to BBCodeContent class
|
Yep. I can see your commit. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When I tried to create a model with BBCodeTextField and edit it through admin app I got this problem. Adding unicode function solves it.