Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Webpack 2 #52

Closed
optikfluffel opened this issue Mar 5, 2017 · 4 comments
Closed

Upgrade to Webpack 2 #52

optikfluffel opened this issue Mar 5, 2017 · 4 comments

Comments

@optikfluffel
Copy link

We should probably migrate to webpack 2 and update all other dependencies along the way too. I could give it a shot during the following week if that's ok with everyone. Any thoughts on that?

@eeue56
Copy link
Contributor

eeue56 commented Mar 6, 2017

Porting the loader is the tricky part - this repo is mainly just boilerplate around that. A PR has already been made for the changes for webpack v2 on the loader, elm-community/elm-webpack-loader#105

I would love some help reviewing stuff there, if you already familiar with that migration.

@jiwhiz
Copy link

jiwhiz commented Mar 6, 2017

@optikfluffel Please review my PR #53 and let me know if you find any issues.

@jiwhiz
Copy link

jiwhiz commented Mar 14, 2017

Sorry @optikfluffel, forgot to watch this repo, so didn't see your review. I updated code based on your feedback. Thanks a lot!.

BTW, I create a new starter project at https://github.com/jiwhiz/elm-bootstrap-webpack-starter, with elm-bootstrap support, and made elm-css-webpack-loader working. Hope you guys give me some feedback. Not a frontend developer, but love Elm so much!

@mcmire
Copy link

mcmire commented Oct 14, 2017

Just rooting around this repo and noticed the changes that have been made recently. With 4a2d21c done, can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants