Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the webpack v2 #105

Closed
wants to merge 0 commits into from
Closed

Conversation

owanturist
Copy link
Contributor

Hey!
I just wanted write some code for support new version of webpack api, but I did something yet while I do it. There are some things like:

  • Added .editorconfig for better support different code editors.
  • Added and configured eslint with plugins.
  • Mocha and chai were swapped to Ava. It make tests more pure and clear.
  • Used temp for creating temporary directories and files for tests.
  • Mock of webpack was swapped to real webpack instant in tests. But I could not support some test cases (like check dependency in watch mode).

There are changes in loader in general like this:

  • I could not understood how the option maxInstances works. And I remove it from loader.
  • Strategy of detecting watching mode was changed. It based on options of loader and memory file system.
  • Promises were refactored and now they more clean and nice.

So, I hope, that you can to merge this pr in the future. And I will waiting for your questions and proposals about it.

Sorry for my English, but I'm trying to make the world of elm a bit better.

@eeue56
Copy link
Contributor

eeue56 commented Mar 3, 2017

I could not understood how the option maxInstances works. And I remove it from loader.

maxInstances is required for ensuring webpack does not crash in some situtations (multiple entry points). It can't be removed

Please split this PR up into small parts, and open new PRs. that will make it easier for me to review and merge.

@owanturist
Copy link
Contributor Author

owanturist commented Mar 4, 2017

@eeue56 thank you for the response. I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants