This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Increase precision to 64bit #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. When I saw the title I was thinking "sorry you're stuck with IEEE floats" but happily it's an easy native fix. |
|
@fredcy Could you have a look at this? This would allow us to use the official package instead of vendoring it into our repo. |
|
LGTM. I've just published it as patch version 1.2.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having issues with the precision when using Mapbox GL in elm due to the fact that this requires 64bit precision. Given that elm
Floatalso supports 64bit precision we would suggest that we increase the internal precision to 64 bit too. The included unit test fails forFloat32Array.