Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing imports in documentation #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfmengels
Copy link

I've noticed a few missing imports in the examples.

A few notes: The imports are not sorted the way that elm-format sorts them. Would you like to see this be done as well?

I've only done it for this module, but I've seen some examples in Test.Html.Query where imports are missing and/or lead to confusion and invalid code. (See for instance Test.Html.Query.keep where text is used from both Html and Test.Html.Selector, and similarly Test.Html.Query.children uses class in the same invalid way). Let me know if you want me to solve this (and if so, indicate how you would prefer to see these collisions resolved). Maybe other modules have import issues, I haven't looked at it yet.

@Janiczek
Copy link
Collaborator

Thanks Jeroen!

The imports are not sorted the way that elm-format sorts them. Would you like to see this be done as well?

Yeah that would be nice!

@Janiczek
Copy link
Collaborator

Let's keep Test.Html.Query for some other day 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants