🐞 Bug fix - add layout can create modules that don't compile.
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elm-land canceled.
|
ryan-haskell
approved these changes
Oct 23, 2022
|
This PR looks great @MattCheely, merging it in now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating a layout, it is possible to request an invalid module name and end up with a module that won't compile. For example:
elm-land add layout:static lowercasewill create a module called
layout.elmwhich cannot compile because modules must begin with an uppercase letterSolution
This adds checks to the
addcommand that automatically upper-cases a lowercase initial letter, and rejects other invalid names with a friendly error message.