Skip to content
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.

Errors from header-parse phase do not get put in --report=json #118

Closed
pauldijou opened this issue Oct 5, 2016 · 3 comments
Closed

Errors from header-parse phase do not get put in --report=json #118

pauldijou opened this issue Oct 5, 2016 · 3 comments

Comments

@pauldijou
Copy link

This will probably join the meta issue for the JSON report but it looks like SYNTAX PROBLEM errors will always return the string to display on the screen rather than a valid JSON. For example, even with --report=json, this is the output of elm-make:

-- SYNTAX PROBLEM -------------- /src/Private.elm

I ran into something unexpected when parsing your code!

16| import Core.Context as Context exposing (PrivateContext)aze
                                                            ^
I am looking for one of the following things:

    whitespace

@process-bot
Copy link

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz evancz changed the title Syntax problem is never a valid JSON Errors from header-parse phase do not get put in --report=json Oct 21, 2016
@7sharp9
Copy link

7sharp9 commented May 8, 2017

I was just looking at tooling issues with non reported errors in the vscode Elm addin and encountered this, it would be good to report all errors to the editor users, I suppose there are work arounds by parsing textually on failure but thats nasty.

For any new user having errors silent is a big issue.

@evancz
Copy link
Contributor

evancz commented Mar 7, 2018

Added to #98. The compiler needs to treat all possible errors exactly the same for this to be plausible. It seems best to batch that with an overall pass for "get editor stuff better" so I added it to a meta issue on that for now. Thanks for the report!

@evancz evancz closed this as completed Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants