Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offset for decoding a new Bytes sequence #10

Merged
merged 1 commit into from Feb 11, 2019
Merged

Fix offset for decoding a new Bytes sequence #10

merged 1 commit into from Feb 11, 2019

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Dec 9, 2018 •
edited

When using Bytes.Decode.bytes the offset of the new DataView is set to the offset of the current Decoder. However, the byteOffset of the current DataView is not taken into account, causing an incorrect offset in the new Bytes sequence (when byteOffset > 0). This PR fixes that and #8.

@icidasset icidasset mentioned this pull request Feb 11, 2019
Closed
@evancz evancz merged commit 9827bfd into elm:master Feb 11, 2019
@evancz
Copy link
Member

evancz commented Feb 11, 2019

Thanks for the PR, and thank you @icidasset for summarizing in #12!

@eriktim eriktim deleted the fix-read-bytes branch February 12, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eriktim @evancz