New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset for decoding a new Bytes sequence #10

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@eriktim
Copy link

eriktim commented Dec 9, 2018

When using Bytes.Decode.bytes the offset of the new DataView is set to the offset of the current Decoder. However, the byteOffset of the current DataView is not taken into account, causing an incorrect offset in the new Bytes sequence (when byteOffset > 0). This PR fixes that and #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment