New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
number is not comparable #1581
Comments
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
You're correct. Sorry for the dupe! |
No need to be sorry @zwilias! As I outline in this thread, I think "duplicate" issues are valuable and very underrated in open source. Your SSCCE looks clearer to me than the ones referenced by @jvoigtlaender, and I added it to the meta issue! Thank you! @jvoigtlaender, in the future, can you just note for me that it belongs in the meta issue? In many of your posts like this, I get the sense that it feels a bit confrontational for the OP. No need for that, especially because I prefer "duplicates" with more examples over comments on existing issues! |
No passive aggression from my side. |
No passive agression or confrontation experienced on this side, I understand @jvoigtlaender is just triaging and happens to have an almost academical knowledge of open issues. Since dupes are preferred over comments, it makes sense to at least ensure they're cross-referenced. |
The new combineRigidSupers function makes sure that the rigid variable always wins and that the rigid variable is a subset of the flex variable. There was also a bug in unifyRigid where the rigid variable would not win! The flex one would win. This accounted for some fraction of the bugs as well. I also try to avoid allocating new rigid content in unifyRigid to maybe make things a bit faster. Fixes #1268 Fixes #1270 Fixes #1281 Fixes #1316 Fixes #1422 Fixes #1581
Fails
results in
Alternatives that do work:
Flipping the args
Doing something with the arg first
Inlining the other number (?)
The text was updated successfully, but these errors were encountered: