Fix Map.!: given key is not an element in the map #1850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge this, it works and fixes the elm-deugger. |
|
Potential fix for #1851 Someone could confirm if it fixes SSCCE in #1753 (comment) |
This was referenced Feb 10, 2019
|
It fixes #1851 can we release this in elm 0.19.1, it would greatly help me to be able to use the debugger. |
|
@Natim have you confirmed the fix? |
|
$ stack init$ stack build
|
Yes I have 👍 |
|
We merged this PR into our fork and extended the reactor so that is capable of compiling with the |
|
Confirmed to be working for me as well (macOS) |
|
cc @evancz |
|
Another confirmation that this fixes the issue for me - before we couldn't build our application with |
|
@evancz there are requests making |
|
doesn't seem this bug wil get fixed until 0.19.1 af2ea2b |
Any idea when it is happening? Just showing which package triggers the error would be a already great improvement. |
|
@evancz I've hit this bug again today. It would be great to have feedback if it will be fixed in 0.19 or not, to engineer our codebases accordingly. |
avoids UnsafePath error with zip-archive >= 0.4 fixes elm#1882
|
This patch adds some logic to avoid the The root issue was that the types for all package dependencies should be available to the compiler when generating the
I think these changes are a better solution to the root problem. They will be available in the 0.19.1 release, so I am going to close this PR but keep the issues about this bug open at least until the fix is confirmed in the alpha period for the next release. |
11 tasks
This was referenced Jul 18, 2019
|
For 0.19.0 my issue was solved by moving Found the map error was failing here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application using the package mdgriffith/elm-ui.
One of the application
Msgdata constructors contains value of typeElement msgfrom the elm-ui library.Declaration of this type is:
Neither the
Internal.Element msgunion type nor theInternalmodule is exposed from the library.This pull request fixes function
extractUnion, which couldn't find such module and type.I'm not sure this is the right way how to solve this issue.