Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow M1 users to continue to install elm via our npm package #2156

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

loganhenson
Copy link
Contributor

@loganhenson loganhenson commented Dec 12, 2020

Quick Summary:

Allow M1 users to continue to install via npm and use the x64:64-bit binary (via rosetta) until we get a native build.

Additional Details

I would like to continue to allow people with M1 macs to install and use Elm through the npm package, and I think this is a decent stop-gap until we can get a native build. Right now the install fails trying to install a url that does not exist (because the darwin/arm64 combo is not covered), this falls back to the x64:64-bit binary download and lets them use Rosetta.

This isn't a problem anywhere else, because the other methods of installation are direct binary downloads, so it asks the user to either install Rosetta or uses Rosetta directly, we just need to make sure we allow them to still get the binary.

Thanks!

…ry (via rosetta) until we get a native build.
@evancz evancz merged commit 65807bf into elm:master Jan 28, 2021
@evancz
Copy link
Member

evancz commented Jan 28, 2021

Thanks to @lydell for pointing me in the right direction on this! And thanks @loganhenson! Seems like a good approach for npm folks until GHC can produce native binaries. (Not sure how Mac installers are meant to work at that point though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants