New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes runtime exception when comparing inequal lists with over 100 elements #1031
Conversation
Sorry for the long delay in responding here, but I finally had a chance to run the tests at this commit (with the 0.19.1 updates from #1059), and they don't pass for me:
|
I think what this all means is that it's the |
Hmm. So the |
I think so, yes. My fix moves both the I should say that I don't have any deep knowledge of how Elm objects get represented as JS objects that's informing me here, I'm just going by what I saw in the browser debugger when I was exploring the original failures from the SSCCE I posted in #1011. That's maybe why I got a bit more elaborate in my test cases than you, as well? I'm happy to open a new PR with my fix rebased onto the current tip of |
Yep, that leaves |
Should we add the extra tests to prevent regressions? |
I'm always a fan of more tests -- esp. for something as critical as I can make a PR with the combined set of tests if you'd like. |
My new PR is #1062 |
This has the same solution as #1018, but uses fuzz testing instead of unit tests. This PR is also not conflated with upgrading the testing code for 0.19.