Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domNode.elm_event_node_ref is undefined in Internet Explorer 11, Edge (early versions) #101

Closed
BumbrT opened this issue Jun 29, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@BumbrT
Copy link

commented Jun 29, 2017

Reproducing in IE11 and early versions of Edge. Chrome, Safari, Firefox, latest Edge not affected.
Elm 0.18
"elm-lang/core": "5.0.0 <= v < 6.0.0",
"elm-lang/dom": "1.1.1 <= v < 2.0.0",
"elm-lang/html": "2.0.0 <= v < 3.0.0",
I tried to build minimum reproduction example, but can't catch this bug.
So i can only reproduce it as a part of large project.
App stops handling events from element, because eventNode is undefined, so click event does not propagates.

Here is my research in source code
http://take.ms/hjwox
http://take.ms/ckJmn
I have no idea how to build smaller example, maybe you can help me with suggestion

UPD: Found WA with using Html.Keyed.node, maybe it can be usefull for someone. I think this makes VDOM merges less complicated.

@process-bot

This comment has been minimized.

Copy link

commented Jun 29, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

I am tracking all of the VirtualDom.map ideas in #105 so that it is clearer how to make coherent changes.

I'll close here, cleaning up the issue queue. The idea is that this content is all available for reference, but easier for me to find. Point is, thanks for the report!

@evancz evancz closed this Jul 7, 2017

@evancz

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

Separately, is this a problem with development builds of IE? Or is it a problem with actually released browsers?

@BumbrT

This comment has been minimized.

Copy link
Author

commented Jul 8, 2017

Reproducing bug in the latest version of IE11 11.413.15063.0
Latest edge behaves correctly.
I can easily reproduce issue in my project. I will try to create SSCCE later, getting no luck with it.

@allenap

This comment has been minimized.

Copy link

commented Jan 24, 2018

@cachar and I were able to work around this, and @lukewestby previously too, by separating the Html.map from the problematic view code by wrapping it in a div:

i.e. from:

viewSomething : Html OtherMsg

viewBiggerThing : Html Msg
viewBiggerThing =
  div [] [ Html.map BiggerOtherMsg viewSomething ]

to:

viewSomething : Html OtherMsg

viewBiggerThing : Html Msg
viewBiggerThing =
    div [] [ Html.map BiggerOtherMsg <| div [] [ viewSomething ] ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.